Test that the coordinator broadcasts spend txs #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielabrozzoni
force-pushed
the
20220201_coord_broadcast_test
branch
from
1e1f8b0
to
256b4b6
Compare
danielabrozzoni
force-pushed
the
20220201_coord_broadcast_test
branch
2 times, most recently
from
8cafa6a
to
cf12dba
Compare
darosior
reviewed
Feb 8, 2022
danielabrozzoni
force-pushed
the
20220201_coord_broadcast_test
branch
from
cf12dba
to
d7fa559
Compare
danielabrozzoni
force-pushed
the
20220201_coord_broadcast_test
branch
from
d7fa559
to
b8b90a8
Compare
I'm not really sure why we would test with a deployment that big (I'm fairly convinced it was just bad copypasta from another test). This should reduce the amount of timeouts in CI.
darosior
reviewed
Feb 9, 2022
| @@ -386,8 +386,8 @@ def test_spends_conflicting(revault_network, bitcoind): | |||
| @pytest.mark.skipif(not POSTGRES_IS_SETUP, reason="Needs Postgres for servers db") | |||
| def test_spend_threshold(revault_network, bitcoind, executor): | |||
| CSV = 20 | |||
| managers_threshold = 3 | |||
| revault_network.deploy(17, 8, csv=CSV, managers_threshold=managers_threshold) | |||
| managers_threshold = 2 | |||
There was a problem hiding this comment.
Comment about the commit message, not this line.
I'm not really sure why we would test with a deployment that
big (I'm fairly convinced it was just bad copypasta from another
test). This should reduce the amount of timeouts in CI.
My rationale was testing larger setups. It should be an explicitly dedicated test, instead so ACK for decreasing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs revault/coordinatord#46